Adds iso-date-time support from ajv-formats #254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrielyea
approved these changes
Sep 25, 2024
Collaborator
|
LGTM |
Eomm
reviewed
Sep 26, 2024
Member
Eomm
left a comment
Eomm
left a comment
There was a problem hiding this comment.
COuld you document it since it seems not defined in the standard?
https://json-schema.org/draft/2020-12/draft-bhutton-json-schema-validation-00#rfc.section.7.3
gurgunday
approved these changes
Sep 29, 2024
Member
|
@fastify/libraries tentative about cutting a release with this in as it's non-standard (as @Eomm rightly stated). |
2 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add iso-date-time and iso-time string formats added in ajv-formats 3.0
Checklist
npm run testandnpm run benchmarkand the Code of conduct